[webkit-reviews] review granted: [Bug 178401] [FrameView::layout cleanup] Subtree should read subtreeLayout. : [Attachment 324033] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 17 11:44:15 PDT 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 178401: [FrameView::layout cleanup] Subtree should read subtreeLayout.
https://bugs.webkit.org/show_bug.cgi?id=178401

Attachment 324033: Patch

https://bugs.webkit.org/attachment.cgi?id=324033&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 324033
  --> https://bugs.webkit.org/attachment.cgi?id=324033
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324033&action=review

> Source/WebCore/page/FrameView.cpp:1359
> +	   if (!layoutRoot || !layoutRoot->needsLayout())

Kinda weird that we can have a m_subtreeLayoutRoot with needsLayout() == false
(if that happens).

> Source/WebCore/page/FrameView.cpp:1392
> +    bool performingSubtreeLayout = false;

or isSubtreeLayout?

> Source/WebCore/page/FrameView.cpp:1505
> +	   ASSERT(allowSubtreeLayout || !performingSubtreeLayout);

Said added ASSERT_IMPLIES which would be appropriate here:
ASSERT_IMPLIES(performingSubtreeLayout, allowSubtreeLayout)


More information about the webkit-reviews mailing list