[webkit-reviews] review denied: [Bug 178394] [FrameView::layout cleanup] Move scrollbars setup logic to a separate function : [Attachment 324030] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 17 11:40:58 PDT 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has denied zalan
<zalan at apple.com>'s request for review:
Bug 178394: [FrameView::layout cleanup] Move scrollbars setup logic to a
separate function
https://bugs.webkit.org/show_bug.cgi?id=178394

Attachment 324030: Patch

https://bugs.webkit.org/attachment.cgi?id=324030&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 324030
  --> https://bugs.webkit.org/attachment.cgi?id=324030
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324030&action=review

> Source/WebCore/page/FrameView.cpp:1325
> +void FrameView::adjustScrollbarsForLayout(bool firstLayout, const
RenderElement& layoutRoot)

Weird to pass in layoutRoot just to have a way to get a Page&.


More information about the webkit-reviews mailing list