[webkit-reviews] review granted: [Bug 178371] de-flakify http/tests/security/cross-frame-access-put.html : [Attachment 323966] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 17 10:27:08 PDT 2017


Tim Horton <thorton at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 178371: de-flakify http/tests/security/cross-frame-access-put.html
https://bugs.webkit.org/show_bug.cgi?id=178371

Attachment 323966: Patch

https://bugs.webkit.org/attachment.cgi?id=323966&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 323966
  --> https://bugs.webkit.org/attachment.cgi?id=323966
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323966&action=review

> LayoutTests/ChangeLog:8
> +	   In the iframe, the test was being run after 0ms.  Sometimes, the
whole iframe hadn't loaded yet,

You should get signoff from the test's author, since it's in security/

> LayoutTests/http/tests/security/cross-frame-access-put.html:33
> +    alert(message.data);

Did you mean to leave this alert here?


More information about the webkit-reviews mailing list