[webkit-reviews] review granted: [Bug 178171] Add preliminary support for fetch event : [Attachment 323978] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 17 09:28:31 PDT 2017


Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 178171: Add preliminary support for fetch event
https://bugs.webkit.org/show_bug.cgi?id=178171

Attachment 323978: Patch

https://bugs.webkit.org/attachment.cgi?id=323978&action=review




--- Comment #21 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 323978
  --> https://bugs.webkit.org/attachment.cgi?id=323978
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323978&action=review

r=me with comments.

> Source/WebCore/bindings/js/JSDOMPromise.cpp:105
> +    WTFCrash();

RELEASE_ASSERT_NOT_REACHED() or ASSERT_NOT_REACHED();

> Source/WebCore/testing/Internals.cpp:4201
> +void Internals::waitFetchEventToFinish(FetchEvent& event,
DOMPromiseDeferred<IDLInterface<FetchResponse>>&& promise)

waitForFetchEventToFinish()

> Source/WebCore/testing/Internals.cpp:4211
> +void Internals::waitExtendableEventToFinish(ExtendableEvent& event,
DOMPromiseDeferred<void>&& promise)

waitForExtendableEventToFinish()

> Source/WebCore/testing/Internals.cpp:4220
> +    return ExtendableEvent::create("ExtendableEvent", { },
Event::IsTrusted::Yes);

ASCIILiteral("ExtendableEvent") ?


More information about the webkit-reviews mailing list