[webkit-reviews] review granted: [Bug 178369] Add and remove cookie partition accordingly in intermediary redirect requests : [Attachment 323976] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 17 09:13:39 PDT 2017
Brent Fulgham <bfulgham at webkit.org> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 178369: Add and remove cookie partition accordingly in intermediary
redirect requests
https://bugs.webkit.org/show_bug.cgi?id=178369
Attachment 323976: Patch
https://bugs.webkit.org/attachment.cgi?id=323976&action=review
--- Comment #10 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 323976
--> https://bugs.webkit.org/attachment.cgi?id=323976
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=323976&action=review
Looks good. Please correct the minor style issues I mentioned before landing.
> Source/WebCore/ChangeLog:14
> + by the TestRunner.
You should mention that you removed an unimplemented method declaration (for
completeness).
> Source/WebCore/loader/ResourceLoadObserver.h:-56
> - WEBCORE_EXPORT void setShouldThrottleObserverNotifications(bool);
I wish the compiler warned about declarations with no implementations.
>
LayoutTests/http/tests/resourceLoadStatistics/add-partitioning-to-redirect.html
:5
> + <script src="../../resources/js-test-pre.js"></script>
Can this just be "js-test.js"?
>
LayoutTests/http/tests/resourceLoadStatistics/add-partitioning-to-redirect.html
:10
> +
I think we prefer to do:
jsTestIsAsync = true;
nowadays.
>
LayoutTests/http/tests/resourceLoadStatistics/add-partitioning-to-redirect.html
:102
> + testRunner.notifyDone();
I think this should be finishJSTest();.
More information about the webkit-reviews
mailing list