[webkit-reviews] review requested: [Bug 176601] Turn recursive tail calls into loops : [Attachment 323710] Moved the splitting of op_enter to UnlinkedCodeBlocks, and correctly recognize when it has happened

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 17 08:56:05 PDT 2017


Robin Morisset <rmorisset at apple.com> has asked	for review:
Bug 176601: Turn recursive tail calls into loops
https://bugs.webkit.org/show_bug.cgi?id=176601

Attachment 323710: Moved the splitting of op_enter to UnlinkedCodeBlocks, and
correctly recognize when it has happened

https://bugs.webkit.org/attachment.cgi?id=323710&action=review




--- Comment #78 from Robin Morisset <rmorisset at apple.com> ---
Comment on attachment 323710
  --> https://bugs.webkit.org/attachment.cgi?id=323710
Moved the splitting of op_enter to UnlinkedCodeBlocks, and correctly recognize
when it has happened

My experiments with inserting LoopHint have not improved performance so far, so
I would like to get this patch landed as is, and make it a separate bug.

The build-bot failure looks very much like a flaky test to me, I don't see how
my patch could break layout. Is there a simple way to convince the buildbot to
try again? Or should I just resubmit the patch?


More information about the webkit-reviews mailing list