[webkit-reviews] review granted: [Bug 178374] ServiceWorkerRegistration should subclass RefCounted<> : [Attachment 323982] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 16 20:47:44 PDT 2017


Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 178374: ServiceWorkerRegistration should subclass RefCounted<>
https://bugs.webkit.org/show_bug.cgi?id=178374

Attachment 323982: Patch

https://bugs.webkit.org/attachment.cgi?id=323982&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 323982
  --> https://bugs.webkit.org/attachment.cgi?id=323982
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323982&action=review

> Source/WebCore/workers/service/ServiceWorkerRegistration.h:40
> -class ServiceWorkerRegistration final : public EventTargetWithInlineData,
public ActiveDOMObject {
> +class ServiceWorkerRegistration final : public EventTargetWithInlineData,
public ActiveDOMObject, public RefCounted<ServiceWorkerRegistration> {

We typically put RefCounted as the first class listed in the inheritance list.


More information about the webkit-reviews mailing list