[webkit-reviews] review granted: [Bug 178222] Web Inspector: Layers tab mistakenly throws out the root element's layer. : [Attachment 323627] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 16 12:57:11 PDT 2017
Brian Burg <bburg at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 178222: Web Inspector: Layers tab mistakenly throws out the root element's
layer.
https://bugs.webkit.org/show_bug.cgi?id=178222
Attachment 323627: Patch
https://bugs.webkit.org/attachment.cgi?id=323627&action=review
--- Comment #6 from Brian Burg <bburg at apple.com> ---
Comment on attachment 323627
--> https://bugs.webkit.org/attachment.cgi?id=323627
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=323627&action=review
r=me
> Source/WebInspectorUI/UserInterface/Views/LayerTreeDetailsSidebarPanel.js:83
> + let layerForNode = layers[0] && layers[0].nodeId ===
this.domNode.id && !layers[0].isGeneratedContent ? layers[0] : null;
This is kind of complicated for one line, but that's okay I guess.
More information about the webkit-reviews
mailing list