[webkit-reviews] review granted: [Bug 178265] Allow modern decoding of URLs : [Attachment 323690] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 16 12:27:16 PDT 2017
Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 178265: Allow modern decoding of URLs
https://bugs.webkit.org/show_bug.cgi?id=178265
Attachment 323690: Patch
https://bugs.webkit.org/attachment.cgi?id=323690&action=review
--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 323690
--> https://bugs.webkit.org/attachment.cgi?id=323690
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=323690&action=review
r=me with suggestion.
> Source/WebCore/platform/URL.h:299
> +std::optional<URL> URL::decode(Decoder& decoder)
When you do this sort of things, could we rewrite the legacy decoder to use the
modern one to avoid duplication?
e.g.
template <class Decoder>
bool URL::decode(Decoder& decoder, URL& url)
{
auto optionalURL = URL::decode(decoder);
if (!optionalURL)
return false;
url = optionalURL.value();
return true;
}
More information about the webkit-reviews
mailing list