[webkit-reviews] review granted: [Bug 178206] [GStreamer][GTK][WPE] update-webkit-libs-jhbuild fails to detect changes in included moduleset files : [Attachment 323535] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Nael Ouedraogo
<nael.ouedp at gmail.com>'s request for review:
Bug 178206: [GStreamer][GTK][WPE] update-webkit-libs-jhbuild fails to detect
changes in included moduleset files
https://bugs.webkit.org/show_bug.cgi?id=178206

Attachment 323535: Patch

https://bugs.webkit.org/attachment.cgi?id=323535&action=review




--- Comment #10 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 323535
  --> https://bugs.webkit.org/attachment.cgi?id=323535
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323535&action=review

r=me if you also update the two install-dependencies scripts. Thanks!

>>> Tools/Scripts/webkitdirs.pm:49
>>> +use XML::LibXML;
>> 
>> This is a new runtime dependency. It should be added to the scripts
Tools/gtk/install-dependencies and Tools/wpe/install-dependencies.
>> The name of the package in Debian is libxml-libxml-perl
>> I will be installing it on the bots so the EWS don't fail anymore due to
this
> 
> For Arch Linux the package is “perl-xml-libxml”:
> 
>   https://www.archlinux.org/packages/extra/x86_64/perl-xml-libxml/

The package name variations for this on the different distros are incredible...
I believe the correct Fedora package is "perl-libxml-perl".

> Tools/Scripts/webkitdirs.pm:1888
> +sub getJhbuildIncludedFilePath

I think this should be called "getJhbuildIncludedFilePaths" since it returns
multiple paths.