[webkit-reviews] review granted: [Bug 178248] SVGPathElement should cache the built-up Path of its non animating pathByteStream() : [Attachment 323875] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 16 11:36:11 PDT 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 178248: SVGPathElement should cache the built-up Path of its non animating
pathByteStream()
https://bugs.webkit.org/show_bug.cgi?id=178248

Attachment 323875: Patch

https://bugs.webkit.org/attachment.cgi?id=323875&action=review




--- Comment #24 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 323875
  --> https://bugs.webkit.org/attachment.cgi?id=323875
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323875&action=review

> Source/WebCore/platform/graphics/cairo/PathCairo.cpp:68
> +    m_path = other.m_path;
> +    other.m_path = nullptr;

Can this just be m_path = WTFMove(other.m_path)?

> Source/WebCore/platform/graphics/cairo/PathCairo.cpp:106
> +    m_path = other.m_path;
> +    other.m_path = nullptr;

Can this just be m_path = WTFMove(other.m_path)?

> Source/WebCore/platform/graphics/cg/PathCG.cpp:119
> +    m_path = other.m_path;
> +    other.m_path = nullptr;

Can this just be m_path = WTFMove(other.m_path)?

> Source/WebCore/platform/graphics/cg/PathCG.cpp:139
> +    m_path = other.m_path;
> +    other.m_path = nullptr;

Can this just be m_path = WTFMove(other.m_path)?

> Source/WebCore/platform/graphics/win/PathDirect2D.cpp:173
> +    m_path = other.m_path;
> +    m_activePath = other.m_activePath;
> +    m_activePathGeometry = other.m_activePathGeometry;
> +    other.m_path = nullptr;
> +    other.m_activePath = nullptr;
> +    other.m_activePathGeometry = nullptr;

Can these WTFMove?

> Source/WebCore/platform/graphics/win/PathDirect2D.cpp:190
> +    m_path = other.m_path;
> +    m_activePath = other.m_activePath;
> +    m_activePathGeometry = other.m_activePathGeometry;

Can these WTFMove?

> Source/WebCore/rendering/svg/SVGPathData.cpp:49
> +	   return path;

Maybe return { } and move the declaration of path lower down.

> Source/WebCore/rendering/svg/SVGPathData.cpp:66
> +	   return path;

Maybe return { } and move the declaration of path lower down.

> Source/WebCore/rendering/svg/SVGPathData.cpp:119
> +	   return path;

Maybe return { } and move the declaration of path lower down.

> Source/WebCore/rendering/svg/SVGPathData.cpp:134
> +	   return path;

Maybe return { } and move the declaration of path lower down.


More information about the webkit-reviews mailing list