[webkit-reviews] review granted: [Bug 174329] Web Inspector: [PARITY] Styles: Command-click on a property name should jump to definition in Resources tab : [Attachment 323794] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 16 11:11:33 PDT 2017
Joseph Pecoraro <joepeck at webkit.org> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 174329: Web Inspector: [PARITY] Styles: Command-click on a property name
should jump to definition in Resources tab
https://bugs.webkit.org/show_bug.cgi?id=174329
Attachment 323794: Patch
https://bugs.webkit.org/attachment.cgi?id=323794&action=review
--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 323794
--> https://bugs.webkit.org/attachment.cgi?id=323794
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=323794&action=review
r=me
> Source/WebInspectorUI/UserInterface/Base/Main.js:1460
> + if (metaKeyDidChange)
> + document.body.classList.toggle("meta-key-pressed",
this.modifierKeys.metaKey);
I wonder how this will affect style recalculations changing a global property
like this. Lets keep an eye out for any possible stutters after this lands.
More information about the webkit-reviews
mailing list