[webkit-reviews] review granted: [Bug 170779] Web Inspector: Modify CSS number values with up key and down key : [Attachment 323865] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 15 20:54:09 PDT 2017


Matt Baker <mattbaker at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 170779: Web Inspector: Modify CSS number values with up key and down key
https://bugs.webkit.org/show_bug.cgi?id=170779

Attachment 323865: Patch

https://bugs.webkit.org/attachment.cgi?id=323865&action=review




--- Comment #10 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 323865
  --> https://bugs.webkit.org/attachment.cgi?id=323865
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323865&action=review

r=me, with a minor nit.

> Source/WebInspectorUI/UserInterface/Views/EditingSupport.js:240
> +	       let modified = WI.incrementElementValue(element, modifyValue);

Nit: change `modifyValue` to `delta` to be consistent with other caller, and
function signature.


More information about the webkit-reviews mailing list