[webkit-reviews] review granted: [Bug 178247] Remove unnecessary include from Document.h : [Attachment 323620] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 15 18:23:08 PDT 2017


Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 178247: Remove unnecessary include from Document.h
https://bugs.webkit.org/show_bug.cgi?id=178247

Attachment 323620: Patch

https://bugs.webkit.org/attachment.cgi?id=323620&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 323620
  --> https://bugs.webkit.org/attachment.cgi?id=323620
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323620&action=review

> Source/WebCore/dom/Document.cpp:5548
> +    return m_touchEventTargets ? m_touchEventTargets->size() : false;

I think we should use && instead of ? : for this.

> Source/WebCore/dom/Document.cpp:5557
> +    return m_touchEventTargets ? m_touchEventTargets->contains(&node) :
false;

Ditto.


More information about the webkit-reviews mailing list