[webkit-reviews] review granted: [Bug 175282] Web Inspector: show warning when recorded Canvas action caused no visual change : [Attachment 323830] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Oct 15 15:46:45 PDT 2017
Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 175282: Web Inspector: show warning when recorded Canvas action caused no
visual change
https://bugs.webkit.org/show_bug.cgi?id=175282
Attachment 323830: Patch
https://bugs.webkit.org/attachment.cgi?id=323830&action=review
--- Comment #22 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 323830
--> https://bugs.webkit.org/attachment.cgi?id=323830
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=323830&action=review
r=me
> Source/WebInspectorUI/UserInterface/Models/Recording.js:58
> - WI.Recording.synthesizeError(WI.UIString("â%sâ is
invalid.").format(action.name));
> + WI.Recording.synthesizeError(WI.UIString("â%sâ is
invalid.").format(this._name));
Nit: This is not in the ChangeLog.
> Source/WebInspectorUI/UserInterface/Models/RecordingAction.js:144
> + } catch (e) {
Style: Could drop the (e) variable since it is not used: `} catch {`
More information about the webkit-reviews
mailing list