[webkit-reviews] review granted: [Bug 178270] Stub out SW Client/Clients : [Attachment 323705] Still adding ChangeLogs, but reviewable without them.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 13 11:06:22 PDT 2017


Andy Estes <aestes at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 178270: Stub out SW Client/Clients
https://bugs.webkit.org/show_bug.cgi?id=178270

Attachment 323705: Still adding ChangeLogs, but reviewable without them.

https://bugs.webkit.org/attachment.cgi?id=323705&action=review




--- Comment #2 from Andy Estes <aestes at apple.com> ---
Comment on attachment 323705
  --> https://bugs.webkit.org/attachment.cgi?id=323705
Still adding ChangeLogs, but reviewable without them.

View in context: https://bugs.webkit.org/attachment.cgi?id=323705&action=review

> Source/WebCore/workers/service/context/Client.idl:31
> +  readonly attribute USVString url;

Needs more spaces

> Source/WebCore/workers/service/context/Client.idl:39
> +  "window",

Ditto

> Source/WebCore/workers/service/context/Clients.idl:31
> +  [NewObject] Promise<any> get(DOMString id);

Ditto

> Source/WebCore/workers/service/context/WindowClient.idl:34
> +  readonly attribute boolean focused;

Ditto


More information about the webkit-reviews mailing list