[webkit-reviews] review granted: [Bug 175209] [Win] When built with VS2017, MiniBrowser crashes on startup. : [Attachment 321836] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 13 09:54:26 PDT 2017


Daniel Bates <dbates at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 175209: [Win] When built with VS2017, MiniBrowser crashes on startup.
https://bugs.webkit.org/show_bug.cgi?id=175209

Attachment 321836: Patch

https://bugs.webkit.org/attachment.cgi?id=321836&action=review




--- Comment #21 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 321836
  --> https://bugs.webkit.org/attachment.cgi?id=321836
Patch

Is this patch working around a compiler quirk of VS2017? If so, we should file
a bug against VS2017 and consider guarding this code behind COMPILER_QUIRK().


More information about the webkit-reviews mailing list