[webkit-reviews] review granted: [Bug 178209] DataTransfer.cpp triggers -Wunused-but-set-variable : [Attachment 323643] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 13 08:30:50 PDT 2017


Wenson Hsieh <wenson_hsieh at apple.com> has granted Tomas Popela
<tpopela at redhat.com>'s request for review:
Bug 178209: DataTransfer.cpp triggers -Wunused-but-set-variable
https://bugs.webkit.org/show_bug.cgi?id=178209

Attachment 323643: Patch

https://bugs.webkit.org/attachment.cgi?id=323643&action=review




--- Comment #5 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 323643
  --> https://bugs.webkit.org/attachment.cgi?id=323643
Patch

I don't think processedFiles is a great name for this local variable...perhaps
make this something like:

bool containsItemsAndFiles = itemListContainsItems && addedFilesFromPasteboard;

...and then ASSERT_UNUSED(containsItemsAndFiles, !containsItemsAndFiles);?


More information about the webkit-reviews mailing list