[webkit-reviews] review granted: [Bug 178178] [GLib] WebKitNavigationAction should tell whether it is a redirect : [Attachment 323435] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 13 01:58:54 PDT 2017


Carlos Garcia Campos <cgarcia at igalia.com> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 178178: [GLib] WebKitNavigationAction should tell whether it is a redirect
https://bugs.webkit.org/show_bug.cgi?id=178178

Attachment 323435: Patch

https://bugs.webkit.org/attachment.cgi?id=323435&action=review




--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 323435
  --> https://bugs.webkit.org/attachment.cgi?id=323435
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323435&action=review

LGTM, thanks!

> Source/WebKit/UIProcess/API/glib/WebKitNavigationAction.cpp:158
> + * Return whether the navigation had a redirect.

@navigation I'm confused here about the use of "had".

> Source/WebKit/UIProcess/API/glib/WebKitNavigationAction.cpp:160
> + * Returns: whether the original navigation was redirected.

for boolean functions we normally use the pattern %TRUE if bla bla bla, or
%FALSE otherwise.


More information about the webkit-reviews mailing list