[webkit-reviews] review granted: [Bug 177313] Web Inspector: Styles Redesign: hook up autocompletion to property names and values : [Attachment 323577] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 12 21:27:08 PDT 2017
Joseph Pecoraro <joepeck at webkit.org> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 177313: Web Inspector: Styles Redesign: hook up autocompletion to property
names and values
https://bugs.webkit.org/show_bug.cgi?id=177313
Attachment 323577: Patch
https://bugs.webkit.org/attachment.cgi?id=323577&action=review
--- Comment #19 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 323577
--> https://bugs.webkit.org/attachment.cgi?id=323577
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=323577&action=review
r=me
> Source/WebInspectorUI/ChangeLog:19
> + Add a preventBlur option so clicking on an completion item doesn't
change the focus and doesn't cause "blur" event on the target text field.
Nit: We typically wrap ChangeLog sentences at some reasonable column (80-100).
Nothing is enforced, we just avoid super long lines.
> Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js:72
> + this._element.append(this._suggestionHintElement);
Nit: I'd still prefer appendChild if already have the element so we know thats
what it would do.
More information about the webkit-reviews
mailing list