[webkit-reviews] review requested: [Bug 178240] Expose some of WKView's WebViewImpl accessors through WKWebViewPrivate : [Attachment 323583] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 12 16:49:48 PDT 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has asked	for review:
Bug 178240: Expose some of WKView's WebViewImpl accessors through
WKWebViewPrivate
https://bugs.webkit.org/show_bug.cgi?id=178240

Attachment 323583: Patch

https://bugs.webkit.org/attachment.cgi?id=323583&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 323583
  --> https://bugs.webkit.org/attachment.cgi?id=323583
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323583&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:403
> + at property (copy, nonatomic, setter=_setUnderlayColor:) NSColor
*_underlayColor;

Can we put the nonatomic first, like the others? Also would be nice to group
this with the the properties below.


More information about the webkit-reviews mailing list