[webkit-reviews] review denied: [Bug 178024] [WinCairo] add WebProcess files for wincairo webkit : [Attachment 323316] Add initial versions of WebProcess files for wincairo webkit, fixed style
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 12 13:34:43 PDT 2017
Alex Christensen <achristensen at apple.com> has denied Stephan Szabo
<stephan.szabo at sony.com>'s request for review:
Bug 178024: [WinCairo] add WebProcess files for wincairo webkit
https://bugs.webkit.org/show_bug.cgi?id=178024
Attachment 323316: Add initial versions of WebProcess files for wincairo
webkit, fixed style
https://bugs.webkit.org/attachment.cgi?id=323316&action=review
--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 323316
--> https://bugs.webkit.org/attachment.cgi?id=323316
Add initial versions of WebProcess files for wincairo webkit, fixed style
View in context: https://bugs.webkit.org/attachment.cgi?id=323316&action=review
> Source/WebKit/WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:40
> +bool InjectedBundle::initialize(const WebProcessCreationParameters&,
API::Object* initializationUserData)
Do we need to use the InjectedBundle on Windows? Couldn't we just leave this
uninitialized? We're trying to reduce/remove the need for this by going
through our use cases that "require" it right now and designing API to do that
from the UIProcess.
> Source/WebKit/WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.cpp:49
> +#if 0
Let's not.
More information about the webkit-reviews
mailing list