[webkit-reviews] review granted: [Bug 178219] Performance: do pixel conformance and texturing in a single step. : [Attachment 323544] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 178219: Performance: do pixel conformance and texturing in a single step.
https://bugs.webkit.org/show_bug.cgi?id=178219

Attachment 323544: Patch

https://bugs.webkit.org/attachment.cgi?id=323544&action=review




--- Comment #7 from Dean Jackson <dino at apple.com> ---
Comment on attachment 323544
  --> https://bugs.webkit.org/attachment.cgi?id=323544
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323544&action=review

> Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm:-226
> -#if PLATFORM(IOS)
> -	       attributes = @{(NSString
*)kCVPixelBufferIOSurfaceOpenGLESFBOCompatibilityKey: @YES};
> -#else
> -	       attributes = @{(NSString
*)kCVPixelBufferIOSurfaceOpenGLFBOCompatibilityKey: @YES};
> -#endif

If we never send these attributes, will we ever get into the
copyVideoTextureToPlatformTexture path? Where does the CVOpenGLTextureRef come
from (as TextureType)? Will m_textureCache->textureFromImage still work without
these options?