[webkit-reviews] review denied: [Bug 178205] [WPE] Remove GLib API functions which use Cairo : [Attachment 323521] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 178205: [WPE] Remove GLib API functions which use Cairo
https://bugs.webkit.org/show_bug.cgi?id=178205

Attachment 323521: Patch

https://bugs.webkit.org/attachment.cgi?id=323521&action=review




--- Comment #8 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 323521
  --> https://bugs.webkit.org/attachment.cgi?id=323521
Patch

The unit tests should not be testing a function that's not in our API. And the
symbol should not be exported by the installed library.

Code using these functions in WebKitWebView should be guarded by #if
PLATFORM(GTK).

When entire API functions are guarded with PLATFORM(GTK), I would move them to
WebKitWebViewGtk, but Carlos Garcia has not been doing that, so let's not start
now. We can ask him why when he's available again.