[webkit-reviews] review granted: [Bug 177792] A JSFunction's ObjectAllocationProfile should watch the poly prototype watchpoint so it can clear its object allocation profile : [Attachment 323373] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 12 01:13:18 PDT 2017


Yusuke Suzuki <utatane.tea at gmail.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 177792: A JSFunction's ObjectAllocationProfile should watch the poly
prototype watchpoint so it can clear its object allocation profile
https://bugs.webkit.org/show_bug.cgi?id=177792

Attachment 323373: patch

https://bugs.webkit.org/attachment.cgi?id=323373&action=review




--- Comment #3 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 323373
  --> https://bugs.webkit.org/attachment.cgi?id=323373
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323373&action=review

r=me

> Source/JavaScriptCore/runtime/FunctionRareData.h:114
> +    class ClearAllocationProfile : public Watchpoint {

How about naming it ClearAllocationProfileWatchpoint?


More information about the webkit-reviews mailing list