[webkit-reviews] review granted: [Bug 177595] run-safari --ios-simulator is no longer working with XCode 9 : [Attachment 323398] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 11 22:37:14 PDT 2017


Daniel Bates <dbates at webkit.org> has granted Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 177595: run-safari --ios-simulator is no longer working with XCode 9
https://bugs.webkit.org/show_bug.cgi?id=177595

Attachment 323398: Patch

https://bugs.webkit.org/attachment.cgi?id=323398&action=review




--- Comment #14 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 323398
  --> https://bugs.webkit.org/attachment.cgi?id=323398
Patch

If we do not support Xcode 9 for iOS WebKit development/we no longer have any
Xcode 9 iOS simulator builders on build.webkit.org/no longer have any Xcode 9
iOS Simulator EWS bots then we should remove the conditional code in
webkitdirs::iosSimulatorApplicationsPath().


More information about the webkit-reviews mailing list