[webkit-reviews] review granted: [Bug 178189] Correct nullptr deref in selection handling : [Attachment 323480] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 11 19:03:02 PDT 2017
Ryosuke Niwa <rniwa at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 178189: Correct nullptr deref in selection handling
https://bugs.webkit.org/show_bug.cgi?id=178189
Attachment 323480: Patch
https://bugs.webkit.org/attachment.cgi?id=323480&action=review
--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 323480
--> https://bugs.webkit.org/attachment.cgi?id=323480
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=323480&action=review
> Source/WebCore/page/DOMSelection.cpp:397
> + auto visibleSelection = selection.selection();
> + if (visibleSelection.isNoneOrOrphaned())
> + return false;
There's no reason to check this condition if we're checking null-ty of
toNormalizedRange. Please remove it.
More information about the webkit-reviews
mailing list