[webkit-reviews] review denied: [Bug 178036] Part 2: Fix -Wcast-qual and -Wunused-lambda-capture warnings in WebCore with new clang compiler : [Attachment 323440] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 11 12:21:49 PDT 2017


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has denied David Kilzer
(:ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 178036: Part 2: Fix -Wcast-qual and -Wunused-lambda-capture warnings in
WebCore with new clang compiler
https://bugs.webkit.org/show_bug.cgi?id=178036

Attachment 323440: Patch v2

https://bugs.webkit.org/attachment.cgi?id=323440&action=review




--- Comment #9 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 323440
  --> https://bugs.webkit.org/attachment.cgi?id=323440
Patch v2

/Volumes/Data/EWS/WebKit/Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp:45:8:
error: unknown type name 'unint8_t'
inline unint8_t* castDataArgumentToCCRSACryptorCreateFromDataIfNeeded(const
uint8_t* value)
       ^
/Volumes/Data/EWS/WebKit/Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp:47:12:
error: cannot initialize return object of type 'int *' with an rvalue of type
'uint8_t *' (aka 'unsigned char *')
    return const_cast<uint8_t*>(value);
	   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/Volumes/Data/EWS/WebKit/Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp:149:30:
error: no matching function for call to 'CCRSACryptorCreateFromData'
    CCCryptorStatus status = CCRSACryptorCreateFromData(
			     ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from
/Volumes/Data/EWS/WebKit/Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp:32:
/Volumes/Data/EWS/WebKit/Source/WebCore/crypto/CommonCryptoUtilities.h:129:28:
note: candidate function not viable: no known conversion from 'int *' to 'const
uint8_t *' (aka 'const unsigned char *') for 2nd argument
extern "C" CCCryptorStatus CCRSACryptorCreateFromData(CCRSAKeyType keyType,
const uint8_t *modulus, size_t modulusLength, const uint8_t *exponent, size_t
exponentLength, const uint8_t *p, size_t pLength, const uint8_t *q, size_t
qLength, CCRSACryptorRef *ref);
			   ^
3 errors generated.


More information about the webkit-reviews mailing list