[webkit-reviews] review granted: [Bug 178172] Re-sync XMLHttpRequests Web-Platform-Tests : [Attachment 323427] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 11 11:36:45 PDT 2017


youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 178172: Re-sync XMLHttpRequests Web-Platform-Tests
https://bugs.webkit.org/show_bug.cgi?id=178172

Attachment 323427: Patch

https://bugs.webkit.org/attachment.cgi?id=323427&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 323427
  --> https://bugs.webkit.org/attachment.cgi?id=323427
Patch

Some tests should be fixed to be actually useful.
Use common/get-host-info.sub.js for that purpose.

View in context: https://bugs.webkit.org/attachment.cgi?id=323427&action=review

>
LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/open-url-worker-orig
in.htm:20
> +	   var worker = new Worker("resources/workerxhr-origin-referrer.js")

Can we fix /workerxhr-origin-referrer.js to not use www2?

>
LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/send-after-setting-d
ocument-domain.htm:12
> +	 var test_base_url =
location.protocol+'//www2.'+location.host+"/XMLHttpRequest/resources/",

Test should be fixed upstream

>
LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-
basic-cors-not-enabled.htm:16
> +	     urlstart = 'www1.'+location.host +
location.pathname.replace(/\/[^\/]*$/, '/')

Test should be fixed upstreamed.

>
LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-
basic-cors.htm:16
> +	     urlstart = 'www1.'+location.host +
location.pathname.replace(/\/[^\/]*$/, '/')

Ditto.

>
LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-
basic-expected.txt:3
> +Note: this test will only work as expected once per browsing session.
Restart browser to re-test.

Can it make things flaky?


More information about the webkit-reviews mailing list