[webkit-reviews] review granted: [Bug 178136] Web Inspector: Make 3D objects selectable in Layers visualization : [Attachment 323355] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 11 11:16:25 PDT 2017


Devin Rousso <webkit at devinrousso.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 178136: Web Inspector: Make 3D objects selectable in Layers visualization
https://bugs.webkit.org/show_bug.cgi?id=178136

Attachment 323355: Patch

https://bugs.webkit.org/attachment.cgi?id=323355&action=review




--- Comment #5 from Devin Rousso <webkit at devinrousso.com> ---
Comment on attachment 323355
  --> https://bugs.webkit.org/attachment.cgi?id=323355
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323355&action=review

r=me, with a few remaining NITs.

> Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:117
> +	   this._renderer.domElement.addEventListener("mousedown",
this._canvasMouseDown.bind(this), false);

NIT: the `false` is unnecessary.

> Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:281
> +WI.Layers3DContentView._unselectedColor = {

The word "unselect" is very weird.  Maybe just use "_color" and
"_selectedColor"?


More information about the webkit-reviews mailing list