[webkit-reviews] review granted: [Bug 178156] Add a SW context process (where SW scripts will actually execute) : [Attachment 323392] PFR

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 11 09:25:40 PDT 2017


Andy Estes <aestes at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 178156: Add a SW context process (where SW scripts will actually execute)
https://bugs.webkit.org/show_bug.cgi?id=178156

Attachment 323392: PFR

https://bugs.webkit.org/attachment.cgi?id=323392&action=review




--- Comment #5 from Andy Estes <aestes at apple.com> ---
Comment on attachment 323392
  --> https://bugs.webkit.org/attachment.cgi?id=323392
PFR

View in context: https://bugs.webkit.org/attachment.cgi?id=323392&action=review

> Source/WebCore/workers/service/server/SWServerRegistration.cpp:86
> +    auto worker = m_server.createWorker(connection, m_registrationKey,
m_currentJob->scriptURL, result.script, WorkerType::Classic);

Surprised the compiler doesn't complain about worker not being used.

> Source/WebCore/workers/service/server/SWServerRegistration.cpp:92
> +    UNUSED_PARAM(workerID);

You could also remove "workerID" from the function signature.

> Source/WebCore/workers/service/server/SWServerRegistration.h:83
> +    double m_lastUpdateTime { 0.0 };

No need for ".0"


More information about the webkit-reviews mailing list