[webkit-reviews] review requested: [Bug 160786] InlineTextBox::isSelected() should only return true for a non-empty selection and remove incorrect FIXME from InlineTextBox::localSelectionRect() : [Attachment 323379] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 10 20:44:16 PDT 2017
Daniel Bates <dbates at webkit.org> has asked for review:
Bug 160786: InlineTextBox::isSelected() should only return true for a non-empty
selection and remove incorrect FIXME from InlineTextBox::localSelectionRect()
https://bugs.webkit.org/show_bug.cgi?id=160786
Attachment 323379: Patch
https://bugs.webkit.org/attachment.cgi?id=323379&action=review
--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Created attachment 323379
--> https://bugs.webkit.org/attachment.cgi?id=323379&action=review
Patch
I did not rename the arguments of InlineTextBox::localSelectionRect() as I did
for InlineTextBox::isSelected() because I felt it would add too much noise to
this patch and I will refactor InlineTextBox::localSelectionRect() sometime
this or next week anyway.
More information about the webkit-reviews
mailing list