[webkit-reviews] review denied: [Bug 176766] Web Inspector: Implement `queryObjects` Command Line API : [Attachment 322029] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 10 19:45:04 PDT 2017


Joseph Pecoraro <joepeck at webkit.org> has denied Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 176766: Web Inspector: Implement `queryObjects` Command Line API
https://bugs.webkit.org/show_bug.cgi?id=176766

Attachment 322029: Patch

https://bugs.webkit.org/attachment.cgi?id=322029&action=review




--- Comment #43 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 322029
  --> https://bugs.webkit.org/attachment.cgi?id=322029
Patch

r-, we need to take an approach that doesn't have the problem of leaking
built-in values, which would be quite problematic.

After talking with Saam we have some possible solutions, but none are trivial.
r- on this patch for now.


More information about the webkit-reviews mailing list