[webkit-reviews] review granted: [Bug 178048] [Payment Request] Implement PaymentRequest.canMakePayment() : [Attachment 323348] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 10 16:36:38 PDT 2017


youenn fablet <youennf at gmail.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 178048: [Payment Request] Implement PaymentRequest.canMakePayment()
https://bugs.webkit.org/show_bug.cgi?id=178048

Attachment 323348: Patch

https://bugs.webkit.org/attachment.cgi?id=323348&action=review




--- Comment #11 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 323348
  --> https://bugs.webkit.org/attachment.cgi?id=323348
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323348&action=review

> Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:343
> +static ExceptionOr<JSC::JSValue> parse(ScriptExecutionContext& context,
const String& string)

This routine is nice and might be useful elsewhere now or in the future.

> Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:405
>      setPendingActivity(this);

I usually like to have setPendingActivity/unsetPendingActivity close one to the
other.
That is made a bit more easy with a call to setPendingActivity and then a
lambda with an unsetPendingActivity inside it.

>
LayoutTests/http/tests/paymentrequest/payment-request-canmakepayment-method.htt
ps.html:33
> +promise_test(async t => {

This mix of async/await with promise_test looks good!

>
LayoutTests/http/tests/paymentrequest/payment-request-canmakepayment-method.htt
ps.html:48
> +	 "if it throws, then it must be a NotAllowedError."

It seems strange that we are not always expecting either an exception or no
exception.


More information about the webkit-reviews mailing list