[webkit-reviews] review denied: [Bug 178132] Bump default cache storage quota to 20MB : [Attachment 323317] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 10 13:02:17 PDT 2017
Alex Christensen <achristensen at apple.com> has denied youenn fablet
<youennf at gmail.com>'s request for review:
Bug 178132: Bump default cache storage quota to 20MB
https://bugs.webkit.org/show_bug.cgi?id=178132
Attachment 323317: Patch
https://bugs.webkit.org/attachment.cgi?id=323317&action=review
--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 323317
--> https://bugs.webkit.org/attachment.cgi?id=323317
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=323317&action=review
> Source/WebKit/NetworkProcess/NetworkProcess.cpp:774
> +void NetworkProcess::setCacheStoragePerOriginQuota(uint64_t quota)
This shouldn't be here.
> Source/WebKit/NetworkProcess/NetworkProcess.h:149
> uint64_t cacheStoragePerOriginQuota() const;
> + void setCacheStoragePerOriginQuota(uint64_t);
These should both be removed and replaced by values on WebsiteDataStore.
> Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h:157
> + uint64_t m_cacheStoragePerOriginQuota {
WebKit::WebsiteDataStore::defaultCacheStoragePerOriginQuota };
This should be completely removed.
> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:187
> + unsigned m_cacheStoragePerOriginQuota {
defaultCacheStoragePerOriginQuota };
uint64_t
More information about the webkit-reviews
mailing list