[webkit-reviews] review granted: [Bug 178139] Layers should be destroyed by RenderLayerModelObject : [Attachment 323328] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 10 12:53:09 PDT 2017
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 178139: Layers should be destroyed by RenderLayerModelObject
https://bugs.webkit.org/show_bug.cgi?id=178139
Attachment 323328: patch
https://bugs.webkit.org/attachment.cgi?id=323328&action=review
--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 323328
--> https://bugs.webkit.org/attachment.cgi?id=323328
patch
View in context: https://bugs.webkit.org/attachment.cgi?id=323328&action=review
> Source/WebCore/rendering/RenderObject.cpp:-1444
> - // FIXME: Would like to do this in RenderBoxModelObject, but the timing
is so complicated that this can't easily
> - // be moved into RenderLayerModelObject::willBeDestroyed().
> - // FIXME: Is this still true?
> - if (hasLayer()) {
> - setHasLayer(false);
> - downcast<RenderLayerModelObject>(*this).destroyLayer();
> - }
> -
Should RenderObject have ASSERT(!hasLayer()) somewhere late in its destruction
to ensure that we didn't re-assign a layer after
RenderLayerModelObject::destroyLayer() ran?
More information about the webkit-reviews
mailing list