[webkit-reviews] review granted: [Bug 178134] Fix compilation when MASM_PROBE (and therefore DFG) are disabled : [Attachment 323318] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 10 12:21:21 PDT 2017
Saam Barati <sbarati at apple.com> has granted Guillaume Emont
<guijemont at igalia.com>'s request for review:
Bug 178134: Fix compilation when MASM_PROBE (and therefore DFG) are disabled
https://bugs.webkit.org/show_bug.cgi?id=178134
Attachment 323318: Patch
https://bugs.webkit.org/attachment.cgi?id=323318&action=review
--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 323318
--> https://bugs.webkit.org/attachment.cgi?id=323318
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=323318&action=review
> Source/JavaScriptCore/bytecode/CodeBlock.cpp:2323
> +#if ENABLE(MASM_PROBE)
This should be:
#if ENABLE(DFGJIT)
or whatever the correct ENABLE name is
> Source/JavaScriptCore/bytecode/CodeBlock.h:80
> +#if ENABLE(MASM_PROBE)
ditto
> Source/JavaScriptCore/bytecode/CodeBlock.h:774
> +#if ENABLE(MASM_PROBE)
> OptimizeAction
updateOSRExitCounterAndCheckIfNeedToReoptimize(DFG::OSRExitState&);
> +#endif
ditto
More information about the webkit-reviews
mailing list