[webkit-reviews] review granted: [Bug 178129] Rebaseline tests at media/modern-media-controls/media-controller : [Attachment 323300] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 10 11:00:20 PDT 2017


Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 178129: Rebaseline tests at media/modern-media-controls/media-controller
https://bugs.webkit.org/show_bug.cgi?id=178129

Attachment 323300: Patch

https://bugs.webkit.org/attachment.cgi?id=323300&action=review




--- Comment #10 from Dean Jackson <dino at apple.com> ---
Comment on attachment 323300
  --> https://bugs.webkit.org/attachment.cgi?id=323300
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323300&action=review

r+ assuming you fix all the EWS failures

> LayoutTests/platform/mac/TestExpectations:1551
>
+media/modern-media-controls/media-controller/media-controller-ios-only-enable-
tap-gesture-recognizer-with-fades-when-idle.html [ Skip ]
>
+media/modern-media-controls/media-controller/media-controller-scale-factor-aud
io.html [ Skip ]
>
+media/modern-media-controls/media-controller/media-controller-scale-factor.htm
l [ Skip ]

Maybe put iOS tests in a sub directory?

> LayoutTests/platform/mac/TestExpectations:1562
> +# These tests are timing-related and can fail due to performance issues on
bots
>
+media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-
enter-and-mouse-leave.html [ Pass Failure ]
>
+media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-
leave-after-play.html [ Pass Failure ]
>
+media/modern-media-controls/media-controller/media-controller-auto-hide-pause.
html [ Pass Failure ]
>
+media/modern-media-controls/media-controller/media-controller-auto-hide-rewind
-with-mouse-enter.html [ Pass Failure ]
> +media/modern-media-controls/media-controller/media-controller-auto-hide.html
[ Pass Failure ]

You should add a comment to the bug to fix these.


More information about the webkit-reviews mailing list