[webkit-reviews] review granted: [Bug 178012] run-webkit-tests: upload test results to multiple servers : [Attachment 323233] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 10 08:17:46 PDT 2017
Lucas Forschler <lforschler at apple.com> has granted review:
Bug 178012: run-webkit-tests: upload test results to multiple servers
https://bugs.webkit.org/show_bug.cgi?id=178012
Attachment 323233: Patch
https://bugs.webkit.org/attachment.cgi?id=323233&action=review
--- Comment #5 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 323233
--> https://bugs.webkit.org/attachment.cgi?id=323233
Patch
This looks good to me. Do you want to try and test it on the UAT server before
pushing to production? We likely need to verify functionality for WebKit and
Internal, although I expect if it works for one, it will work for the other.
Can we add a unit test which tests 0, 1, >1 results servers?
More information about the webkit-reviews
mailing list