[webkit-reviews] review requested: [Bug 177932] [GTK] New API to add, retrieve and delete cookies via WebKitCookieManager : [Attachment 323302] Patch proposal
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 10 06:44:43 PDT 2017
Mario Sanchez Prada <mario at webkit.org> has asked for review:
Bug 177932: [GTK] New API to add, retrieve and delete cookies via
WebKitCookieManager
https://bugs.webkit.org/show_bug.cgi?id=177932
Attachment 323302: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=323302&action=review
--- Comment #3 from Mario Sanchez Prada <mario at webkit.org> ---
Created attachment 323302
--> https://bugs.webkit.org/attachment.cgi?id=323302&action=review
Patch proposal
See a patch proposal attached. The only change I did compared to my original
proposal in the mailing list is that the functions add_cookie() and
get_cookies() now receive a SoupURI* parameter instead of a const char*, to
make sure that they are valid HTTP/HTTPs URLs (and also because it's easier and
more natural to validate that those are valid URIs for HTTP/HTTPs right at the
beginning of the functions).
Please review, thanks!
More information about the webkit-reviews
mailing list