[webkit-reviews] review denied: [Bug 178065] Add an option to show raw numbers of run-benchmark results. : [Attachment 323159] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 9 21:10:58 PDT 2017
Ryosuke Niwa <rniwa at webkit.org> has denied dewei_zhu at apple.com's request for
review:
Bug 178065: Add an option to show raw numbers of run-benchmark results.
https://bugs.webkit.org/show_bug.cgi?id=178065
Attachment 323159: Patch
https://bugs.webkit.org/attachment.cgi?id=323159&action=review
--- Comment #10 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 323159
--> https://bugs.webkit.org/attachment.cgi?id=323159
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=323159&action=review
We need unit tests for this.
> Tools/ChangeLog:9
> + Adding '--show-raw-values' option allows showing raw numbers for
run-benchmark results.
Why don't we make this the default option??
> Tools/Scripts/webkitpy/benchmark_runner/benchmark_results.py:81
> + if is_a_list_of_int:
> + formated_value_str = ', '.join(map(str, values))
> + else:
> + formated_value_str = ',
'.join(map('{:.3f}'.format, values))
I guess we don't want to show decimal points if they're whole number?
More information about the webkit-reviews
mailing list