[webkit-reviews] review granted: [Bug 178098] Web Inspector: Network Tab - Show initially loaded resources even if network info not logged : [Attachment 323236] [PATCH] Proposed Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 9 17:38:41 PDT 2017
Devin Rousso <webkit at devinrousso.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 178098: Web Inspector: Network Tab - Show initially loaded resources even
if network info not logged
https://bugs.webkit.org/show_bug.cgi?id=178098
Attachment 323236: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=323236&action=review
--- Comment #5 from Devin Rousso <webkit at devinrousso.com> ---
Comment on attachment 323236
--> https://bugs.webkit.org/attachment.cgi?id=323236
[PATCH] Proposed Fix
View in context: https://bugs.webkit.org/attachment.cgi?id=323236&action=review
r=me. Would like to see another patch tho, specifically for the ChangeLog
fixes.
> Source/WebInspectorUI/ChangeLog:12
> + So treat hasResposne
Oops. :P
> Source/WebInspectorUI/ChangeLog:23
> + While this path is not taken pre-table, change this so that if it is
> + that the resouce is not lost and is instead a pending insertion.
"so that if it is that" is a bit awkward :/
> Source/WebInspectorUI/UserInterface/Models/Resource.js:656
> + return !isNaN(this._statusCode) || this._finished;
Will this cause problems with WI.ResourceHeadersContentView (or
WI.ResourceTimelineDataGridNode)?
> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:105
> +
WI.frameResourceManager.addEventListener(WI.FrameResourceManager.Event.MainFram
eDidChange, this._mainFrameDidChange, this);
Can we move this to an `initialLayout()`? The other event listeners too?
More information about the webkit-reviews
mailing list