[webkit-reviews] review denied: [Bug 178034] Add API to clean CacheStorage data : [Attachment 323213] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 9 14:53:47 PDT 2017


Chris Dumez <cdumez at apple.com> has denied youenn fablet <youennf at gmail.com>'s
request for review:
Bug 178034: Add API to clean CacheStorage data
https://bugs.webkit.org/show_bug.cgi?id=178034

Attachment 323213: Patch

https://bugs.webkit.org/attachment.cgi?id=323213&action=review




--- Comment #9 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 323213
  --> https://bugs.webkit.org/attachment.cgi?id=323213
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323213&action=review

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:441
> +	   CacheStorage::Engine::clearEngines([this, callbackID] {

This seems wrong if websiteDataTypes does not contain
WebsiteDataType::DOMCache.

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:493
> +	   completionHandler = [this, origins, callbackID] {

I am assuming origins is a container types, in which case we would want to
avoid the copy here.

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:501
> +	   clearDiskCacheEntries(originDatas, WTFMove(completionHandler));

If websiteDataTypes.contains(WebsiteDataType::DOMCache) is false, the
completionHandler will be a no-op and this will fail to send the IPC back to
the parent process.

> Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:83
> +    // FIXME: Support fetching entries

notImplemented(); ?

> Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:106
> +    auto cleanTaskHandler = adoptRef(*new
ClearTasksHandler(WTFMove(completionHandler)));

We may want a create() factory to abstract this.

> Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:113
> +    auto cleanTaskHandler = adoptRef(*new
ClearTasksHandler(WTFMove(completionHandler)));

ditto.

> Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:362
> +static void deleteFolder(const String& filename)

Should this be in FileSystem.h / FileSystem.cpp so that it can be reused? It
seems useful.


More information about the webkit-reviews mailing list