[webkit-reviews] review granted: [Bug 178012] run-webkit-tests: upload test results to multiple servers : [Attachment 323034] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 9 14:21:56 PDT 2017


Lucas Forschler <lforschler at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 178012: run-webkit-tests: upload test results to multiple servers
https://bugs.webkit.org/show_bug.cgi?id=178012

Attachment 323034: Patch

https://bugs.webkit.org/attachment.cgi?id=323034&action=review




--- Comment #3 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 323034
  --> https://bugs.webkit.org/attachment.cgi?id=323034
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323034&action=review

>
Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:39
5
>	   """Download JSON file that only contains test

Since you are adding server_index here, you should bubble it up to get_json, as
an entry point for utilizing the new functionality.


More information about the webkit-reviews mailing list