[webkit-reviews] review denied: [Bug 175282] Web Inspector: show warning when recorded Canvas action caused no visual change : [Attachment 317533] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 9 11:38:27 PDT 2017


Brian Burg <bburg at apple.com> has denied Devin Rousso <webkit at devinrousso.com>'s
request for review:
Bug 175282: Web Inspector: show warning when recorded Canvas action caused no
visual change
https://bugs.webkit.org/show_bug.cgi?id=175282

Attachment 317533: Patch

https://bugs.webkit.org/attachment.cgi?id=317533&action=review




--- Comment #12 from Brian Burg <bburg at apple.com> ---
Comment on attachment 317533
  --> https://bugs.webkit.org/attachment.cgi?id=317533
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317533&action=review

r- based on Matt's comments, which I think are a nicer direction.

> Source/WebInspectorUI/UserInterface/Views/RecordingContentView.css:65
> +    margin-right: 4px;

This needs RTL treatment.


More information about the webkit-reviews mailing list