[webkit-reviews] review granted: [Bug 175951] Web Inspector: Views should explicitly remove event listeners from managers/Frame : [Attachment 319015] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 9 11:32:06 PDT 2017


Brian Burg <bburg at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 175951: Web Inspector: Views should explicitly remove event listeners from
managers/Frame
https://bugs.webkit.org/show_bug.cgi?id=175951

Attachment 319015: Patch

https://bugs.webkit.org/attachment.cgi?id=319015&action=review




--- Comment #2 from Brian Burg <bburg at apple.com> ---
Comment on attachment 319015
  --> https://bugs.webkit.org/attachment.cgi?id=319015
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319015&action=review

r=me. Please rebase and upload a new patch to EWS before landing.

> Source/WebInspectorUI/UserInterface/Views/QuickConsole.js:106
> +

Technically outside the scope of this patch, but this should also unregister
from WI.consoleDrawer and WI.TabBrowser.


More information about the webkit-reviews mailing list