[webkit-reviews] review granted: [Bug 178072] Make HashMap::keys() and HashMap::values() work with WTF::map/WTF::copyToVector : [Attachment 323177] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 9 10:50:44 PDT 2017
Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 178072: Make HashMap::keys() and HashMap::values() work with
WTF::map/WTF::copyToVector
https://bugs.webkit.org/show_bug.cgi?id=178072
Attachment 323177: Patch
https://bugs.webkit.org/attachment.cgi?id=323177&action=review
--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 323177
--> https://bugs.webkit.org/attachment.cgi?id=323177
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=323177&action=review
> Source/WebCore/platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.h:80
> + WTF::SizedIteratorRange<OptionContainer,
OptionContainer::iterator::Values> options() { return m_options.values(); }
I’d like the type here to be OptionContainer::ValuesIteratorRange. Can we add
some "using" to HashMap.h so we can do it that way instead of having to write
out the type like this?
> Source/WebKit/Shared/AsyncRequest.h:141
> + WTF::SizedIteratorRange<RequestMap, RequestMap::iterator::Values>
values()
Ditto.
> Source/WebKit/UIProcess/WebProcessProxy.h:101
> + WTF::SizedIteratorRange<WebPageProxyMap,
WebPageProxyMap::const_iterator::Values> pages() const { return
m_pageMap.values(); }
And again.
More information about the webkit-reviews
mailing list