[webkit-reviews] review granted: [Bug 177981] Web Inspector: Network Tab - Search Headers Detail View : [Attachment 323142] [PATCH] Proposed Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 9 10:26:16 PDT 2017
Brian Burg <bburg at apple.com> has granted Joseph Pecoraro <joepeck at webkit.org>'s
request for review:
Bug 177981: Web Inspector: Network Tab - Search Headers Detail View
https://bugs.webkit.org/show_bug.cgi?id=177981
Attachment 323142: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=323142&action=review
--- Comment #7 from Brian Burg <bburg at apple.com> ---
Comment on attachment 323142
--> https://bugs.webkit.org/attachment.cgi?id=323142
[PATCH] Proposed Fix
View in context: https://bugs.webkit.org/attachment.cgi?id=323142&action=review
r=me
We might benefit from some sort of SearchController[Delegate] to extract out
the common search related state thats duplicated in each content view that
overrides the various ContentView search methods. That might give us a uniform
search delegate protocol between ContentViews and Sidebars.
> Source/WebInspectorUI/ChangeLog:11
> + Rename "Dom" to "DOM" in utility function.
OK
> Source/WebInspectorUI/UserInterface/Views/ResourceHeadersContentView.js:43
> + this._searchDOMChanges = [];
Nit: searchDOMHighlightChanges to match other content views?
> Source/WebInspectorUI/UserInterface/Views/ResourceHeadersContentView.js:428
> + let highlightElement = this._searchResults[index];
Nit: highlightedElement
More information about the webkit-reviews
mailing list