[webkit-reviews] review granted: [Bug 177931] AX: [ATK] STATE_CHECKABLE should be removed from radio buttons in radiogroups with aria-readonly="true" : [Attachment 322820] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 9 09:34:38 PDT 2017


chris fleizach <cfleizach at apple.com> has granted Joanmarie Diggs (irc: joanie)
<jdiggs at igalia.com>'s request for review:
Bug 177931: AX: [ATK] STATE_CHECKABLE should be removed from radio buttons in
radiogroups with aria-readonly="true"
https://bugs.webkit.org/show_bug.cgi?id=177931

Attachment 322820: Patch

https://bugs.webkit.org/attachment.cgi?id=322820&action=review




--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 322820
  --> https://bugs.webkit.org/attachment.cgi?id=322820
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322820&action=review

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:2107
> +	   return radioGroup ? radioGroup->ariaReadOnlyValue() != "true" :
true;

do we want to do equalIgnoringCase() for the != true


More information about the webkit-reviews mailing list