[webkit-reviews] review granted: [Bug 178051] direct-construct-arity-mismatch.js can have GCs that take ~70ms if you force poly proto and disable generational GC : [Attachment 323100] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 7 18:06:30 PDT 2017


Saam Barati <sbarati at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 178051: direct-construct-arity-mismatch.js can have GCs that take ~70ms if
you force poly proto and disable generational GC
https://bugs.webkit.org/show_bug.cgi?id=178051

Attachment 323100: the patch

https://bugs.webkit.org/attachment.cgi?id=323100&action=review




--- Comment #9 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 323100
  --> https://bugs.webkit.org/attachment.cgi?id=323100
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323100&action=review

r=me

> Source/JavaScriptCore/runtime/IndexingType.h:76
> +static const IndexingType IndexingTypeMayBePrototype      = 0x80;

Nice I was thinking of exactly this. I agree this is much better than a large
hashset

> Source/JavaScriptCore/runtime/PrototypeKey.h:45
> +	   : m_inlineCapacity(1)

There’s no technical reason to do this, but I think it’s clearer to use
UINT_MAC here. After initially reading it, I was worried that it was wrong, but
then realized we had default initializers below


More information about the webkit-reviews mailing list